refactor: expose snapshot utilities in a public header - #932
Merged
Merged
Conversation
smaheshwar-pltr
approved these changes
Sep 12, 2026
smaheshwar-pltr
left a comment
smaheshwar-pltr
left a comment
Contributor
There was a problem hiding this comment.
+1 on this change! (I also wanted to do this actually - smaheshwar-pltr#4)
wgtmac
approved these changes
Sep 13, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks @zhjwpku and @smaheshwar-pltr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making SnapshotUtil public lets downstream integrations reuse snapshot traversal, time lookup, and schema resolution logic. Java impl already uses it outside the core library: Spark uses
schemaFor, and Flink usesancestorsBetween.Exposing the C++ equivalent would support similar use cases without duplicating that logic.